Update request.js documentation #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies how to send form data. `.field()` works for multi-part forms, but according to the [SuperAgent documentation](https://visionmedia.github.io/superagent/#post-/-put-requests) `.send()` should be used to send the post data as `application/x-www-form-urlencoded`. This addresses issue #86. There is an older pull request by @BenAychh, but it modified the README.md file directly. According to the discussion, the README.md file is generated based on request.js, and so the documentation should be modified here.
|
Great work @ZackWard! Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies how to send form data.
.field()works for multi-part forms, but according to the SuperAgent documentation.send()should be used to send the post data asapplication/x-www-form-urlencoded. This addresses issue #86. There is an older pull request by @BenAychh, but it modified the README.md file directly. According to the discussion, the README.md file is generated based on request.js, and so the documentation should be modified here.