ci: build before release, commit assets, remove .npmrc #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austince
force-pushed
the
ci/fix-npm-token
branch
5 times, most recently
from
ae0702e
to
4e06ae4
Compare
austince
force-pushed
the
ci/fix-npm-token
branch
from
4e06ae4
to
4e9e980
Compare
keithamus
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More (and hopefully last) tweaks for semantic releasing:
.npmrcso we don't need anNPM_TOKENfor every stage, and the npm semantic-release plugin will dynamically create one when needed.I've figured out why the
NPM_TOKENisn't be correctly set as well: previously we were using the Travis npm deploy, where just the API key was encrypted, but now we need it to be an environment variable with a name. I don't have publish rights to npm, but can someone generate a token and then encrypt it like this?travis encrypt NPM_TOKEN=$NPM_TOKENAlso, can we remove the Sauce travis env variables?