feat: drop support for node < 10 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austince
force-pushed
the
feat/drop-node-support
branch
from
1225641
to
2495476
Compare
|
🙈 🤞🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently overriding the NPM version in the release step, which I think is the reason the CI release is failing yet again (though further along, again). https://github.com/chaijs/chai-http/runs/1979587374#step:5:93
Since npm@6 is now legacy and no longer installed w/ any LTS node, we should upgrade it anyway, so might as well be now.
Since node 8 is EOL and we're trying to do a major release anyway, also might as well happen now.
Also: