Issue 91: npm run posttest' fails when COVERALLS_REPO_TOKEN is unset

[farmisen]

#91

Testing correctly if the COVERALLS_REPO_TOKEN env variable is not empty.

[meeber]

@farmisen thanks for the PR!

The problem with this change is that Travis CI will no longer submit code coverage to Coveralls because $COVERALLS_REPO_TOKEN isn't set in that environment. In fact, I suspect that's why the test script was coded this way in the first place.

If my suspicion is correct, and it was originally coded this way on purpose, then I'd say there's room for improvement so that it continues submitting code coverage to Coveralls when run via Travis CI, but doesn't throw an error in a non-Travis environment where $COVERALLS_REPO_TOKEN isn't set.

[farmisen]

got it - going to see what I can do.

[farmisen]

@meeber, I did push some changes to make sure coveralls was invoked after a successful travis run and I have checked at https://coveralls.io/github/chaijs/chai-http and the coverage data for this PR are showing yet they still show as pending on this page. I am not familiar with coveralls but I am wondering if it could not be a config problem?

[meeber]

@farmisen let's wait for @keithamus before doing any more work on this.

My personal opinion is that code coverage should only be submitted to Coveralls when either:

1. The test script is run from within a Travis CI environment
2. A user manually launches a Coveralls-specific script

Your PR addresses the first point, but it also submits code coverage to Coveralls by default when $COVERALLS_REPO_TOKEN is present. I suspect this isn't desired functionality, but I'm just speculating, so let's wait for @keithamus :D

[keithamus]

Thanks for the PR @farmisen! Thanks for pinging me on this one @meeber.

I was actually planning on going through all of the chai projects and standardising the build & test process using type-detect as a base (see https://github.com/chaijs/type-detect/blob/master/package.json#L25-L36). @farmisen how do you feel about taking what is in type-detect and reworking this PR to feature that?