chai@4.1.2 #1037
chai@4.1.2 #1037
Conversation
| @@ -10017,380 +9992,7 @@ function isPrimitive(value) { | |||
| return value === null || typeof value !== 'object'; | |||
| } | |||
|
|
|||
| },{"type-detect":36}],36:[function(require,module,exports){ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Looks like something funky has happened here. Is it maybe type-detect was deduped?
There was a problem hiding this comment.
Okay, looks like type-detect was deduped, 2 copies were present prior to this commit.
There was a problem hiding this comment.
Yikes, what the hell is that? :|
Erm, hang on, let me look into this. I actually did a fresh checkout and ran npm install . after cloning. Then followed up with the make release-patch (as you explained earlier), and there were no errors displayed in my terminal, so...
There was a problem hiding this comment.
It's all good. deep-eql and chai both rely on type-detect - but up until now they each relied on a different version. This is a good thing. No worries!
|
Someone else from @chaijs/chai want to approve this? |
|
Can't look at this closely right now but we need to make sure upgrading deep-eql to a new major version isn't a breaking change for chai that also requires a new major version |
|
@meeber Running λ Chai (master): make test
up to date in 2.411s
==> [Test :: Node.js]
․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
446 passing (1s)
==> [Browser :: build]
==> [Test :: Karma (PhantomJS)]
31 08 2017 22:37:47.623:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/
31 08 2017 22:37:47.627:INFO [launcher]: Launching browser PhantomJS with unlimited concurrency
31 08 2017 22:37:47.633:INFO [launcher]: Starting browser PhantomJS
31 08 2017 22:37:57.705:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)]: Connected on socket _TSQpe9Kzs9aTsLmAAAA with id 41608741
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 320 of 320 SUCCESS (0.632 secs / 0.537 secs) |
|
Okay thanks, looks like deep-eql received major version bump due to dropping support for node 0.12, which chai core already did previously, so no concerns from me there. This lgtm |
|
If it's not done by time I get off work, ill try to carve out time to do the merge and release tonight |
|
Awesome, thank you so much! |
This release fixes a bug when running in certain environments, and includes a few minor documentation fixes.
Bug Fixes
deep-eqlto version 3.0.0 (Update deep-eql to the latest version 🚀 #1020; @greenkeeperio-bot)Docs