Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-error #1528

Merged
merged 1 commit into from Jul 26, 2023
Merged

Update check-error #1528

merged 1 commit into from Jul 26, 2023

Conversation

koddsson
Copy link
Member

Since it's now an ES Module! :)

@koddsson koddsson requested a review from a team as a code owner July 21, 2023 20:49
@voxpelli
Copy link

@koddsson I see a new release for check-error on npm, but nothing in https://github.com/chaijs/check-error – no new tag or commits that refers to 2.0.0

As for chai itself, you need to alter how its loaded here:

exports.checkError = require('check-error');

require() can't load ESM-modules, you have to use (await import()).default instead.

Copy link

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

@koddsson
Copy link
Member Author

As for chai itself, you need to alter how its loaded here:

I don't know what branch this file is in, but I'm targetting the 5.x.x branch, which doesn't have the require function call.

@voxpelli
Copy link

I don't know what branch this file is in, but I'm targetting the 5.x.x branch, which doesn't have the require function call.

Right, I missed that part as it wasn't mentioned in the PR itself and neither any link to any milestone or such :)

@koddsson
Copy link
Member Author

@keithamus; I don't have merge rights, so I can't land this myself.

It also might be good to remove node12 and node14 as required builds in the repo settings, since they are never going to be reported.

@koddsson koddsson merged commit c6481e0 into chaijs:5.x.x Jul 26, 2023
3 checks passed
@koddsson koddsson deleted the update-check-error branch July 26, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants