Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document possible a/an matcher parameters #520

Closed
jurko-gospodnetic opened this issue Sep 22, 2015 · 3 comments
Closed

Document possible a/an matcher parameters #520

jurko-gospodnetic opened this issue Sep 22, 2015 · 3 comments

Comments

@jurko-gospodnetic
Copy link
Contributor

The values passed to a/an matchers seem to correspond to the type-detect library's results reported for specific objects. That means that since that library got introduced, e.g. new Error(...) is no longer detected as a object and is now detected as an error instead.

Could the documentation on those matchers be updated?

@keithamus
Copy link
Member

Thanks for the issue @jurko-gospodnetic, that sounds like a great idea! PR very much wanted 😄

@keithamus
Copy link
Member

I'll point out that the site has yet to be updated - it's getting quite stale but we need to spend some time redeveloping it to have automated builds.

The documentation for an is here (L127-155 of assertions.js) and the docs have been updated for the new behaviour (with an exception of Error missing). Feel free to include error as an example, and when the new site gets built it'll be reflected!

@jurko-gospodnetic
Copy link
Contributor Author

Added pull request #521 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants