Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests failing with .bin/karma: No such file or directory #212

Closed
wants to merge 2 commits into from

Conversation

romario333
Copy link
Contributor

I try to run tests like this:

npm install
make test

It fails with:

==> [Test :: Karma (PhantomJS)]
make: ./node_modules/.bin/karma: No such file or directory
make: *** [test-phantom] Error 1

Using karma version 0.10.x instead of canary fixes it for me.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 55fb0e0 on romario333:master into f82f43f on chaijs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e07e57f on romario333:master into f82f43f on chaijs:master.

@romario333
Copy link
Contributor Author

Sorry, I'm mixing two things in this pull-requests. I'm going to open new pull-request for each.

@romario333 romario333 closed this Nov 25, 2013
@logicalparadox
Copy link
Member

According to the change made in karma-runner/karma@c7d4627 we can still use a bin. Instead of downgrading lets update the Makefile to point to node_modules/karma/bin/karma instead of the npm installed .bin/karma.

@romario333
Copy link
Contributor Author

Quick note: this pull request mixes two things together. I have opened new PR for this: #213

Are there any good reasons to depend on the unstable version of karma? Stable (0.10) seems to be working just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants