New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #166 - configurable threshold in objDisplay. #251

Merged
merged 2 commits into from Mar 18, 2014

Conversation

Projects
None yet
2 participants
@romario333
Contributor

romario333 commented Mar 18, 2014

This PR replaces PR #214.

Implementation notes:

  • I have moved includeStack and showDiff properties to config.js. Original properties on Assertion are still there - they log deprecation warning and delegate to new properties at config.js.
  • config.js is accessible either via var config = require('config') or chai.config
  • Documentation should be changed (I don't know how):

logicalparadox added a commit that referenced this pull request Mar 18, 2014

Merge pull request #251 from romario333/threshold3
Fix issue #166 - configurable threshold in objDisplay.

@logicalparadox logicalparadox merged commit b638a36 into chaijs:master Mar 18, 2014

1 check passed

default The Travis CI build passed
Details
@logicalparadox

This comment has been minimized.

Member

logicalparadox commented Mar 18, 2014

Perfect, thanks! I will take care of the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment