Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: comment out broken tests in Safari 10 #869

Merged
merged 1 commit into from Nov 17, 2016
Merged

test: comment out broken tests in Safari 10 #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 12 additions & 6 deletions test/should.js
View file
Open in desktop
Expand Up @@ -2205,7 +2205,9 @@ describe('should', function() {
false.should.be.extensible;
}, 'expected false to be extensible');

if (typeof Proxy === 'function') {
// A bug in Safari 10 causes the below test to fail. It can be re-enabled
// once the bug is fixed. See https://github.com/chaijs/chai/issues/855.
/*if (typeof Proxy === 'function') {
var proxy = new Proxy({}, {
isExtensible: function() {
throw new TypeError();
Expand All @@ -2216,7 +2218,7 @@ describe('should', function() {
// .extensible should not suppress errors, thrown in proxy traps
proxy.should.be.extensible;
}, { name: 'TypeError' });
}
}*/
});

it('sealed', function() {
Expand Down Expand Up @@ -2255,7 +2257,9 @@ describe('should', function() {
false.should.not.be.sealed;
}, 'expected false to not be sealed');

if (typeof Proxy === 'function') {
// A bug in Safari 10 causes the below test to fail. It can be re-enabled
// once the bug is fixed. See https://github.com/chaijs/chai/issues/855.
/*if (typeof Proxy === 'function') {
var proxy = new Proxy({}, {
ownKeys: function() {
throw new TypeError();
Expand All @@ -2269,7 +2273,7 @@ describe('should', function() {
// .sealed should not suppress errors, thrown in proxy traps
proxy.should.be.sealed;
}, { name: 'TypeError' });
}
}*/
});

it('frozen', function() {
Expand Down Expand Up @@ -2308,7 +2312,9 @@ describe('should', function() {
false.should.not.be.frozen;
}, 'expected false to not be frozen');

if (typeof Proxy === 'function') {
// A bug in Safari 10 causes the below test to fail. It can be re-enabled
// once the bug is fixed. See https://github.com/chaijs/chai/issues/855.
/*if (typeof Proxy === 'function') {
var proxy = new Proxy({}, {
ownKeys: function() {
throw new TypeError();
Expand All @@ -2322,6 +2328,6 @@ describe('should', function() {
// .frozen should not suppress errors, thrown in proxy traps
proxy.should.be.frozen;
}, { name: 'TypeError' });
}
}*/
});
});