Refactor utils.addChainableMethod
helper
#900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Object.setPrototypeOf
instead of__proto__
Object.setPrototypeOf
is more strict than__proto__
: it throws on failure instead of being silent.__proto__
is in Annex B of the spec; using it is kinda discouraged.__proto__
(before it was defined onObject.prototype
) .Object.setPrototypeOf
reads better 馃槃.__proto__
andObject.setPrototypeOf
or neither of them.When we drop IE < 11, we would simplify
addChainableMethod
even more.Remove hardcoded non-configurable function keys
They used to cause troubles in ancient IEs, but work fine in IE.