Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple symbols and sort fails - Cannot convert a Symbol value to a string #83

Merged
merged 3 commits into from Nov 5, 2022

Conversation

snewcomer
Copy link
Contributor

Screen Shot 2022-02-28 at 9 13 25 AM

@snewcomer snewcomer force-pushed the sn/bug-multiple branch 4 times, most recently from df9d805 to 5a03ebc Compare February 28, 2022 15:18
@snewcomer
Copy link
Contributor Author

ha

Screen Shot 2022-02-28 at 9 00 50 AM

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@snewcomer
Copy link
Contributor Author

snewcomer commented Nov 5, 2022

@keithamus 👋 I reverted part of this PR and kept the tests. All seems to be good now!

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants