Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO for v2 Release #15

Closed
8 of 9 tasks
keithamus opened this issue Nov 15, 2019 · 4 comments · Fixed by #25
Closed
8 of 9 tasks

TODO for v2 Release #15

keithamus opened this issue Nov 15, 2019 · 4 comments · Fixed by #25

Comments

@keithamus
Copy link
Member

keithamus commented Nov 15, 2019

Here's a short list of things we'll probably need to do to get this ready for publishing:

Bare Minimum

  • get npm t passing locally (fails on safari for me)
  • Get CI passing (fails on lint check it seems now fails on saucelabs)
  • Totally rewrite the readme so it makes more sense.

Probably should do:

  • Update all deps/devdeps so we're in a good clean state

Would be really nice to have

  • Migrate to github actions and drop travis ci
  • Separate lint check in GH Actions
  • Separate node/browser tests in GH actions

Stretch goals

  • Migrate commitlint to github actions
  • Migrate codecov to github actions checks
@pcorpet
Copy link
Contributor

pcorpet commented Oct 14, 2020

Hi there, is anything missing for v2?

@pcorpet
Copy link
Contributor

pcorpet commented Jan 18, 2021

@keithamus @flaambe need any help for a v2 release? It seems that everything's ready

@flaambe
Copy link
Contributor

flaambe commented Jan 20, 2021

@pcorpet Hi. It would be better, if @keithamus has time to outline the next steps. I thought the main goal of v2 release is to bring it to chai.

@keithamus
Copy link
Member Author

The goal of a v2 release is indeed to fold it into Chai. I've been quite burnt out recently on the Chai project, I've been struggling to be motivated to do anything on it.

Having said that I just went ahead and published this to npm as 2.0.0. If someone would like to make a PR to chai with the upgrade and we can look to merging it and see what needs to happen to chai to cut a release. Also if someone would be kind enough to prepare some release notes for the 2.0.0 release of this package I can put them into the release notes which I'm sure others will hugely appreciate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants