Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CI passing and update all deps #16

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Get CI passing and update all deps #16

merged 4 commits into from
Feb 25, 2020

Conversation

flaambe
Copy link
Contributor

@flaambe flaambe commented Feb 22, 2020

Not sure about "eslint-disable-next-line complexity"

Related to issue #15

@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2e67501). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage          ?   59.08%           
=========================================
  Files             ?       19           
  Lines             ?      435           
  Branches          ?        0           
=========================================
  Hits              ?      257           
  Misses            ?      178           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e67501...36d9722. Read the comment docs.

@flaambe flaambe closed this Feb 22, 2020
@flaambe flaambe reopened this Feb 22, 2020
@flaambe
Copy link
Contributor Author

flaambe commented Feb 22, 2020

I think Travis broken, maybe reopen new PR

@flaambe flaambe changed the title Fix eslint errors Get CI passing and update all deps Feb 23, 2020
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @flaambe! Super appreciated!

I think CI might pass if the dist key gets removed from travis.yml:

language: node_js

trusty is pretty old now, I'd wager it won't work properly.

@flaambe
Copy link
Contributor Author

flaambe commented Feb 24, 2020

@keithamus Thanks for review. Now it's failing on node v11
Edit1: Maybe drop v11 and use v12
Edit2: Saucelabs authentication error now and on node v10 ./node_modules/.bin/npm: No such file or directory

@keithamus
Copy link
Member

I'll merge this for now, as it improves things considerably. We can follow up with more fixes for Travis (or just move to GitHub Actions)

@keithamus keithamus merged commit 20bfb6e into chaijs:master Feb 25, 2020
@flaambe flaambe deleted the fix-eslint-errors branch February 25, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants