Add readme note about security concerns #57
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a security vulnerability report about this repository, saying that users can accidentally assign arbitrary values to root objects, such as
Object.prototype
. Here's the full message:Our code works as intended, it is designed to set arbitrary values to arbitrary paths. There are myriad ways that unsanitised input could effect the host environment, not limited to just
__proto__
; for examplesetPathValue(Object, 'prototype.baz', 'It works!')
would have the same effect. I relayed this to the npm security team, who suggested we update the readme on this package to reflect this issue:This PR just adds a readme note to that effect.