phantomjs-prebuilt@2.1.11 breaks build 🚨 #66
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
phantomjs-prebuilt just published its new version 2.1.11.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As phantomjs-prebuilt is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 46 commits .
fdb40fe
bump version
df332c6
Merge pull request #593 from Medium/nicks/error
3a2c9e6
bump version
644fd3c
Merge pull request #592 from Medium/nicks/error
dc41be9
Better error handling on the run() method
e649b58
Merge pull request #588 from cognitom/run
46af78b
Merge pull request #590 from thoop/master
1b41891
Adds description about exec() and run()
85d49df
Better error handling
a17cf74
fixing variable name in tests
fb9629f
fix issue with tryPhantomjsInLib on Elastic Beanstalk
85025f8
Adds methods: exec() and run()
08dd985
Merge pull request #586 from Medium/nicks/bump
d32d2c2
bump versions
fc9d31a
Merge pull request #585 from strongloop-forks/bundled-dependencies
There are 46 commits in total. See the full diff.