chore: update package dependencies #94
Conversation
| "eslint-config-strict": "^8.5.0", | ||
| "eslint-plugin-filenames": "^0.2.0", | ||
| "ghooks": "^1.0.1", | ||
| "browserify": "^14.3.0", |
There was a problem hiding this comment.
FYI, while Browserify 14 technically no longer supports IE10, the main reason is due to it upgrading the Buffer module, which we don't make use of - so I feel like we can upgrade for this case - as it means less effort in trying to determine what packages need upgrading later on. However I also can see this is a slippery slope - as all we need to do is reference Buffer once to break browserify builds for IE10 - so I'm happy to take direction here.
There was a problem hiding this comment.
I think that we won't need to reference Buffer anytime soon given the purpose of this library.
If we ever need to we can always go back to the old version.
I agree with this change. Also, thanks for explaining, it's always good to have this kind of comment available on GitHub if we ever need to see the reason why we're doing this.
| "eslint-config-strict": "^8.5.0", | ||
| "eslint-plugin-filenames": "^0.2.0", | ||
| "ghooks": "^1.0.1", | ||
| "browserify": "^14.3.0", |
There was a problem hiding this comment.
I think that we won't need to reference Buffer anytime soon given the purpose of this library.
If we ever need to we can always go back to the old version.
I agree with this change. Also, thanks for explaining, it's always good to have this kind of comment available on GitHub if we ever need to see the reason why we're doing this.
| "eslint": "^3.19.0", | ||
| "eslint-config-strict": "^13.0.0", | ||
| "eslint-plugin-filenames": "^1.1.0", | ||
| "husky": "^0.13.3", |
There was a problem hiding this comment.
I didn't know this. Seems awesome!
There was a problem hiding this comment.
Yeah sorry - I should have mentioned; ghooks is now deprecated in favour of husky.
|
Looks like the build is failing here because eslint no longer supports Node 0.10 or 0.12. We have PR #96 which should be merged first, and then this one will pass. |
|
@keithamus, ah sorry, I didn't see that. Seems like an ultra easy issue to solve btw. I've just approved that PR. |
keithamus
force-pushed
the
chore/update-all-dependencies
branch
from
b03d641
to
0a18483
Compare
This commit updates all dependencies. After this we should be able to get gk running properly - as I'm not sure it is right now.