Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ConnectionState abstraction #70

Merged
merged 6 commits into from
Jan 30, 2024
Merged

feat: ConnectionState abstraction #70

merged 6 commits into from
Jan 30, 2024

Conversation

merklefruit
Copy link
Contributor

@merklefruit merklefruit commented Jan 24, 2024 •
edited
Loading

This PR introduces the ConnectionState enum to replace the PublisherState in pubsub and generalize over reqrep for handling of backoff and inactive connection strategies.

Tasks

  • Refactored the msg_socket/backoff module in msg_socket/connection with backoff and state inside.
  • Added usage of ConnectionState in the sub driver poll impl
  • Added usage of ConnectionState in the req driver poll impl
  • Updated the book (if necessary)

@merklefruit merklefruit changed the title feat: reqrep compression (request only) feat: ConnectionState Jan 24, 2024
@merklefruit merklefruit changed the title feat: ConnectionState feat: ConnectionState abstraction Jan 24, 2024
@merklefruit merklefruit added C-chore Category: Chore A-socket Area: Sockets labels Jan 24, 2024
@merklefruit merklefruit self-assigned this Jan 24, 2024
@merklefruit merklefruit added C-feature Category: Feature and removed C-chore Category: Chore labels Jan 24, 2024
@merklefruit merklefruit linked an issue Jan 24, 2024 that may be closed by this pull request
Fix ReqSocket connection retries #60
Closed
Base automatically changed from feat/reqrep/compression to main January 26, 2024 12:33
@merklefruit merklefruit marked this pull request as ready for review January 30, 2024 12:04
mempirate
mempirate approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@mempirate mempirate merged commit 65605e4 into main Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mempirate mempirate mempirate approved these changes

Assignees

@merklefruit merklefruit

Labels
A-socket Area: Sockets C-feature Category: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ReqSocket connection retries
2 participants
@merklefruit @mempirate