Merge pull request #284 from corochann/bbox_inches_option

improve plot
chainer · Dec 12, 2018 · 2962246 · 2962246
2 parents 8e1a578 + 8b8eaf0
commit 2962246
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/chainer_chemistry/saliency/visualizer/image_visualizer.py b/chainer_chemistry/saliency/visualizer/image_visualizer.py
@@ -23,7 +23,8 @@ def __init__(self, logger=None):
 
     def visualize(self, saliency, image=None, save_filepath=None,
                   scaler=abs_max_scaler, title='Image saliency map',
-                  cmap=cm.jet, alpha=0.5, show_colorbar=False):
+                  cmap=cm.jet, alpha=0.5, show_colorbar=False,
+                  bbox_inches='tight'):
         """Visualize or save `saliency` of image.
 
         Args:
@@ -41,7 +42,7 @@ def visualize(self, saliency, image=None, save_filepath=None,
             alpha (float): alpha value of fore ground saliency. This option is
                 used only when `image` is set.
             show_colorbar (bool): show colorbar in plot or not.
-
+            bbox_inches (str or Bbox or None): used for `plt.savefig` option.
         """
         # --- type check ---
         if saliency.ndim == 3:
@@ -95,6 +96,6 @@ def visualize(self, saliency, image=None, save_filepath=None,
         if show_colorbar:
             fig.colorbar(im)
         if save_filepath:
-            plt.savefig(save_filepath)
+            plt.savefig(save_filepath, bbox_inches=bbox_inches)
         else:
             plt.show()
diff --git a/chainer_chemistry/saliency/visualizer/table_visualizer.py b/chainer_chemistry/saliency/visualizer/table_visualizer.py
@@ -12,7 +12,7 @@ class TableVisualizer(BaseVisualizer):
     def visualize(self, saliency, feature_names=None, save_filepath=None,
                   num_visualize=-1, scaler=abs_max_scaler,
                   sort='descending', title='Feature Importance', color='b',
-                  xlabel='Importance'):
+                  xlabel='Importance', bbox_inches='tight'):
         """Visualize or save `saliency` in bar plot.
 
         Args:
@@ -30,6 +30,7 @@ def visualize(self, saliency, feature_names=None, save_filepath=None,
             title (str or None): title of plot
             color (str): color of bar in plot
             xlabel (str): x label legend
+            bbox_inches (str or Bbox or None): used for `plt.savefig` option.
 
         """
         # --- type check ---
@@ -78,6 +79,6 @@ def visualize(self, saliency, feature_names=None, save_filepath=None,
         plt.yticks(range(num_visualize), feature_names)
         plt.xlabel(xlabel)
         if save_filepath:
-            plt.savefig(save_filepath)
+            plt.savefig(save_filepath, bbox_inches=bbox_inches)
         else:
             plt.show()