Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change assertion message #162

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Change assertion message #162

merged 1 commit into from
Apr 27, 2018

Conversation

mihaimorariu
Copy link
Contributor

This PR fixes the assertion message for the available preprocessors, when max_atoms is larger than out_size.

@codecov-io
Copy link

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is 80%.

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   77.92%   77.92%           
=======================================
  Files          79       79           
  Lines        3388     3388           
=======================================
  Hits         2640     2640           
  Misses        748      748

corochann
corochann approved these changes Apr 27, 2018
View reviewed changes
Copy link
Member

@corochann corochann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corochann corochann merged commit 8d87cb4 into chainer:master Apr 27, 2018
@mihaimorariu mihaimorariu deleted the fix/preprocessor_assertion branch April 27, 2018 07:22
@mottodora mottodora added this to the 0.4.0 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corochann corochann corochann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mihaimorariu @codecov-io @corochann @mottodora