Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smiles parser #204

Merged
merged 1 commit into from
Jun 29, 2018
Merged

smiles parser #204

merged 1 commit into from
Jun 29, 2018

Conversation

corochann
Copy link
Member

No description provided.

@corochann corochann requested a review from mottodora June 29, 2018 05:02
@codecov-io
Copy link

codecov-io commented Jun 29, 2018

Codecov Report

Merging #204 into master will increase coverage by 0.35%.
The diff coverage is 98.75%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   79.38%   79.73%   +0.35%     
==========================================
  Files          97       99       +2     
  Lines        4274     4353      +79     
==========================================
+ Hits         3393     3471      +78     
- Misses        881      882       +1

@mottodora
Copy link
Member

LGTM!

@mottodora mottodora merged commit 376f759 into chainer:master Jun 29, 2018
@corochann corochann deleted the smiles_parser branch June 29, 2018 05:15
@mottodora mottodora added this to the 0.4.0 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants