Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PRCAUCEvaluator #210

Merged
merged 5 commits into from
Jul 3, 2018
Merged

Implement PRCAUCEvaluator #210

merged 5 commits into from
Jul 3, 2018

Conversation

mottodora
Copy link
Member

@mottodora mottodora commented Jul 2, 2018 •
edited
Loading

Rel. #178

  • BatchEvaluator
  • Refactor ROCAUCEvaluator
  • PRCAUCEvaluator
  • Unit test
  • Documents

@mottodora mottodora changed the title [WIP] Implement PRCAUCScore [WIP] Implement PRCAUCEvaluator Jul 2, 2018
@mottodora mottodora changed the title [WIP] Implement PRCAUCEvaluator Implement PRCAUCEvaluator Jul 3, 2018
@mottodora mottodora requested a review from corochann July 3, 2018 01:53
@corochann corochann mentioned this pull request Jul 3, 2018
Closed
5 tasks
@codecov-io
Copy link

codecov-io commented Jul 3, 2018 •
edited
Loading

Codecov Report

Merging #210 into master will increase coverage by 2.02%.
The diff coverage is 96.05%.

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   79.78%   81.81%   +2.02%     
==========================================
  Files          99      104       +5     
  Lines        4363     4827     +464     
==========================================
+ Hits         3481     3949     +468     
+ Misses        882      878       -4

corochann
corochann approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@corochann corochann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corochann corochann merged commit 51475bc into chainer:master Jul 3, 2018
@mottodora mottodora added this to the 0.4.0 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corochann corochann corochann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mottodora @codecov-io @corochann