Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using frac option in get_molnet_dataset function #230

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

mottodora
Copy link
Member

Please merge after #216

Copy link
Member

@corochann corochann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #230 into master will decrease coverage by 0.27%.
The diff coverage is 10%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   81.96%   81.68%   -0.28%     
==========================================
  Files         106      106              
  Lines        5134     5154      +20     
==========================================
+ Hits         4208     4210       +2     
- Misses        926      944      +18

@corochann corochann merged commit c9f24b8 into chainer:master Jul 18, 2018
@mottodora mottodora added this to the 0.4.0 milestone Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants