-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard interface of RNN units #1271
Comments
I think each RNN unit function
Each unit
A statefull unit
For variable length inputs, we need return parts of hidden states as The interface of cuDNN's RNN helps you because it supports many types of RNNs in one API. |
@unnonouno Thank you for your proposal. My vague idea was almost same as you. And also thank you for suggestion of cuDNN RNN's API. How do you think of the separation of |
|
I agree with you in that |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions. |
This issue is closed as announced. Feel free to re-open it if needed. |
Currently, several types of RNN units are implemented (stateful/stateless, LSTM/GRU). And we also have PRs that implement other kind of RNN units (SGU, DSGU (#1115), MGU (#1101), peephole (#1207), stacked GRU and stacked LSTM (#1124) etc.).
It would be cumbersome if these RNN units had different APIs as we sometimes switch RNN units within the model without change the interfaces. So it is preferable for those RNN units to have standard interface that are common to them.
The text was updated successfully, but these errors were encountered: