Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify to_gpu in RNN tests #4046

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Simplify to_gpu in RNN tests #4046

merged 2 commits into from
Dec 6, 2017

Conversation

unnonouno
Copy link
Member

I replaced to_gpu in RNN tests.
related to #4045

@unnonouno unnonouno added cat:test Test or CI related. to-be-backported Pull request that should be backported. labels Dec 6, 2017
@niboshi
Copy link
Member

niboshi commented Dec 6, 2017

cuda.to_gpu now supports lists and None. You can simply use it like cuda.to_gpu(self.xs).

@unnonouno
Copy link
Member Author

Does it support nested lists?

@niboshi
Copy link
Member

niboshi commented Dec 6, 2017

Oh, I see. It does not.

@niboshi niboshi self-assigned this Dec 6, 2017
@niboshi niboshi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Dec 6, 2017
@unnonouno unnonouno mentioned this pull request Dec 6, 2017
Merged
@niboshi
Copy link
Member

niboshi commented Dec 6, 2017

LGTM!

@niboshi niboshi merged commit a25a164 into chainer:master Dec 6, 2017
niboshi added a commit to niboshi/chainer that referenced this pull request Dec 6, 2017
@niboshi
Merge pull request chainer#4046 from unnonouno/improve-rnn-test-to-gpu
b93a60a 
Simplify to_gpu in RNN tests
@niboshi niboshi mentioned this pull request Dec 6, 2017
Merged
@niboshi niboshi added this to the v4.0.0b2 milestone Dec 6, 2017
@unnonouno unnonouno deleted the improve-rnn-test-to-gpu branch December 6, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v4.0.0b2
Development

Successfully merging this pull request may close these issues.
2 participants
@unnonouno @niboshi