Deprecate sep argument of PrintHook
#4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaehashi
reviewed
Mar 16, 2018
| @@ -22,7 +23,7 @@ class PrintHook(function_hook.FunctionHook): | |||
| Chainer's library code. | |||
|
|
|||
| Attributes: | |||
| sep: Separator of print function. | |||
| sep: *(deprecated since v4.0.0)* Ignored. | |||
There was a problem hiding this comment.
This is a list of attributes, not arguments, so is it better to keep self.sep = sep as is?
There was a problem hiding this comment.
Oh, I suspect it was intended to be argument documentation...
But I agree. I will keep it (and change Attributes to Args).
kmaehashi
added
the
cat:enhancement
kmaehashi
added
the
st:test-and-merge
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is never used, becaue there's only one argument to
print.