Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eps from batch normalization statistics #4505

Merged
merged 3 commits into from Mar 20, 2018

Conversation

toslunar
Copy link
Member

Fix that eps is doubly added in test mode. This PR changes the behavior of F.batch_normalization if it is called without cudnn. (Therefore it also changes L.BatchNormalization.)

@okuta okuta self-assigned this Mar 20, 2018
@okuta okuta added cat:bug Bug report or fix. to-be-backported Pull request that should be backported. labels Mar 20, 2018
@okuta okuta added this to the v5.0.0a1 milestone Mar 20, 2018
@okuta
Copy link
Member

okuta commented Mar 20, 2018

LGTM!

@okuta okuta merged commit da6bca3 into chainer:master Mar 20, 2018
okuta added a commit to okuta/chainer that referenced this pull request Mar 20, 2018
Remove eps from batch normalization statistics
okuta added a commit to okuta/chainer that referenced this pull request Mar 23, 2018
Remove eps from batch normalization statistics
@toslunar toslunar deleted the fix-bn-eps-twice branch April 25, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug Bug report or fix. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants