Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctest #4506

Merged
merged 1 commit into from Mar 23, 2018
Merged

Fix doctest #4506

merged 1 commit into from Mar 23, 2018

Conversation

okuta
Copy link
Member

@okuta okuta commented Mar 20, 2018

No description provided.

@okuta okuta added the cat:test Test or CI related. label Mar 20, 2018
@kmaehashi
Copy link
Member

How about marking the doctest as SKIP (considering this behavior is tested in the unit test)?

>>> dataset.concat_examples(w)  # doctest: +SKIP

Other solutions proposed in the document seems inappropriate for example codes. https://docs.python.org/3/library/doctest.html#warnings

@kmaehashi kmaehashi self-assigned this Mar 22, 2018
@kmaehashi kmaehashi added the to-be-backported Pull request that should be backported. label Mar 22, 2018
@kmaehashi kmaehashi added this to the v5.0.0a1 milestone Mar 22, 2018
@kmaehashi kmaehashi added the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Mar 22, 2018
@okuta
Copy link
Member Author

okuta commented Mar 23, 2018

I fixed.

@hvy
Copy link
Member

hvy commented Mar 23, 2018

jenkins, test this please.

@kmaehashi kmaehashi added st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. and removed st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. labels Mar 23, 2018
@kmaehashi kmaehashi merged commit fce32c7 into chainer:master Mar 23, 2018
@kmaehashi
Copy link
Member

LGTM!

kmaehashi added a commit to kmaehashi/chainer that referenced this pull request Mar 23, 2018
@kmaehashi
Merge pull request chainer#4506 from okuta/fix-doctest
5c02742 
Fix doctest
@kmaehashi kmaehashi mentioned this pull request Mar 23, 2018
Merged
@okuta okuta deleted the fix-doctest branch June 25, 2018 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kmaehashi kmaehashi

Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v5.0.0a1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okuta @kmaehashi @hvy