Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Replace variable.data with variable.array in variable.py #5488

Merged
merged 1 commit into from
Oct 18, 2018
Merged

[backport] Replace variable.data with variable.array in variable.py #5488

merged 1 commit into from
Oct 18, 2018

Conversation

okuta
Copy link
Member

@okuta okuta commented Oct 15, 2018

Backport of #5417

@okuta
Merge pull request chainer#5417 from crcrpar/use-array-instead-of-dat…
c069fed 
…a-in-variable-file

replace variable.data with variable.array in chainer.variable.py
@okuta
Copy link
Member Author

okuta commented Oct 15, 2018

[automatic post] Jenkins, test this please.

@okuta okuta added backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces. labels Oct 15, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit c069fed, target branch v5) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

toslunar
toslunar approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar
Copy link
Member

Jenkins, test this please.

@toslunar toslunar self-assigned this Oct 18, 2018
@toslunar
Copy link
Member

The Jenkins failure (tests.chainer_tests.functions_tests.connection_tests.test_convolution_nd.TestConvolutionND_param_40.test_backward_gpu) is unrelated to the PR.

@toslunar toslunar merged commit 9840fea into chainer:v5 Oct 18, 2018
@toslunar toslunar added this to the v5.0.0 milestone Oct 18, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit c069fed, target branch v5) succeeded!

@okuta okuta deleted the bp-5417-use-array-instead-of-data-in-variable-file branch October 21, 2018 11:30
@kmaehashi kmaehashi changed the title [backport] replace variable.data with variable.array in chainer.variable.py [backport] Replace variable.data with variable.array in variable.py Oct 25, 2018
@crcrpar crcrpar mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
backport Pull request that is backported from a more recent version. cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@okuta @chainer-ci @toslunar