Avoid unnecessary copy in ndarray.astype
#5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toslunar
changed the title
ndarray.astypendarray.astype
|
This PR does not fix difficult ones like |
|
Jenkins, test this please. |
toslunar
added
cat:enhancement
|
Jenkins CI test (for commit febca9c, target branch master) failed with status FAILURE. |
toslunar
force-pushed
the
astype-nocopy
branch
from
febca9c
to
741d2c7
Compare
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 741d2c7, target branch master) succeeded! |
|
LGTM |
beam2d
added a commit
to beam2d/chainer
that referenced
this pull request
Nov 5, 2018
Avoid unnecessary copy in `ndarray.astype`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would improve the performance.