Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve installation guide of ChainerMN #5656

Merged
merged 4 commits into from
Dec 19, 2018
Merged

Improve installation guide of ChainerMN #5656

merged 4 commits into from
Dec 19, 2018

Conversation

kmaehashi
Copy link
Member

No description provided.

@kmaehashi kmaehashi added cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported. ChainerMN Related to ChainerMN. labels Nov 13, 2018
keisukefukuda
keisukefukuda reviewed Nov 13, 2018
View reviewed changes
docs/source/chainermn/installation/guide.rst Outdated
* MPI

* openmpi 1.10.7 2.1.2
* openmpi 1.10.7, 2.1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind removing 1.10.7 from tested MPI versions?
If you think that change should be in an another PR, it's OK and I am willing to work on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I removed it.

Just to make sure, do you still expect OpenMPI 1.10.7 to work with current ChainerMN (you want to remove it just because you don't test that configuration), or it won't work any more?
(If possible, I think it's better to add "Supported Environment (versions)" section in addition to "Tested Environments" section.)

@keisukefukuda keisukefukuda self-assigned this Nov 13, 2018
@toslunar
Copy link
Member

ping @keisukefukuda

@keisukefukuda
Copy link
Member

LGTM!!
And sorry for my late response

@keisukefukuda keisukefukuda merged commit ed3eae6 into chainer:master Dec 19, 2018
@kmaehashi kmaehashi deleted the improve-chainermn-install-guide branch December 19, 2018 07:00
@kmaehashi
Copy link
Member Author

Thanks! Could you make a backport PR?

@keisukefukuda
Copy link
Member

Got it! I will create a backport to 5.x branch!

@chainer-ci
Copy link
Member

@keisukefukuda This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@keisukefukuda
Copy link
Member

keisukefukuda commented Dec 27, 2018 via email

@keisukefukuda keisukefukuda mentioned this pull request Dec 27, 2018
Merged
@keisukefukuda
Copy link
Member

done #5937

@toslunar toslunar added this to the v6.0.0b2 milestone Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keisukefukuda keisukefukuda keisukefukuda left review comments

Assignees

@keisukefukuda keisukefukuda

Labels
cat:document Documentation such as function documentations, comments and tutorials. ChainerMN Related to ChainerMN. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v6.0.0b2
Development

Successfully merging this pull request may close these issues.
4 participants
@kmaehashi @toslunar @keisukefukuda @chainer-ci