Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to test against new chainerx.GradientError #5787

Merged
merged 1 commit into from Dec 6, 2018

Conversation

hvy
Copy link
Member

@hvy hvy commented Dec 6, 2018

A new error type chainerx.GradientError was introduced but some Python tests were not updated accordingly. This PR fixes those failing tests.

@hvy hvy added cat:bug Bug report or fix. cat:test Test or CI related. labels Dec 6, 2018
@hvy
Copy link
Member Author

hvy commented Dec 6, 2018

jenkins, test this please.

@hvy hvy added this to the v6.0.0b2 milestone Dec 6, 2018
@niboshi
Copy link
Member

niboshi commented Dec 6, 2018

LGTM

@hvy hvy removed the cat:bug Bug report or fix. label Dec 6, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 370e078, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@hvy
Copy link
Member Author

hvy commented Dec 6, 2018

For the record, the Jenkins failure seems unrelated.

@niboshi niboshi merged commit 8f30e6d into chainer:master Dec 6, 2018
@niboshi niboshi self-assigned this Dec 6, 2018
@hvy hvy deleted the fix-chainerx-test-array branch December 6, 2018 07:02
@niboshi niboshi changed the title Fix to test against new chainerx.GradientError Fix to test against new chainerx.GradientError Dec 6, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 370e078, target branch master) succeeded!

@niboshi niboshi added the ChainerX Related to ChainerX. label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. ChainerX Related to ChainerX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants