Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F.get_item backward for ChainerX #6991

Merged
merged 2 commits into from Apr 23, 2019
Merged

Fix F.get_item backward for ChainerX #6991

merged 2 commits into from Apr 23, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Apr 18, 2019

Fixes #6986

Merge #6990 first.

@niboshi niboshi added the ChainerX Related to ChainerX. label Apr 18, 2019
@niboshi niboshi added this to Ready to Review in ChainerX sprint backlog via automation Apr 18, 2019
@niboshi niboshi added the st:blocked-by-another-pr State indicating that another ticket is preventing this ticket from being closed/merged. label Apr 18, 2019
@niboshi niboshi changed the title Fix F.get_item backward for ChainerX Fix F.get_item backward for ChainerX Apr 18, 2019
@niboshi niboshi mentioned this pull request Apr 18, 2019
Merged
@asi1024 asi1024 added the cat:enhancement Implementation that does not break interfaces. label Apr 22, 2019
@asi1024 asi1024 moved this from Ready to Review to Needs Changes in ChainerX sprint backlog Apr 22, 2019
@hvy
Copy link
Member

hvy commented Apr 23, 2019

Let's update the branch now that #6990 is merged.

@hvy hvy removed the st:blocked-by-another-pr State indicating that another ticket is preventing this ticket from being closed/merged. label Apr 23, 2019
@hvy
Copy link
Member

hvy commented Apr 23, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 089220e (ea475dc):

@hvy hvy added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Apr 23, 2019
@hvy hvy self-assigned this Apr 23, 2019
@hvy hvy moved this from Needs Changes to Waiting for CI in ChainerX sprint backlog Apr 23, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 089220e, target branch master) succeeded!

@hvy
Copy link
Member

hvy commented Apr 23, 2019

LGTM!

@hvy hvy merged commit 9cf5228 into chainer:master Apr 23, 2019
ChainerX sprint backlog automation moved this from Waiting for CI to Done Apr 23, 2019
@hvy hvy removed the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Apr 23, 2019
@hvy hvy added this to the v7.0.0a1 milestone Apr 23, 2019
@hvy hvy mentioned this pull request Apr 23, 2019
Closed
@niboshi niboshi deleted the get-item-chainerx branch October 31, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hvy hvy

Labels
cat:enhancement Implementation that does not break interfaces. ChainerX Related to ChainerX.
Projects
ChainerX sprint backlog
  
Done
Milestone
v7.0.0a1
Development

Successfully merging this pull request may close these issues.

Support ChainerX in F.GetItem backward
5 participants
@niboshi @hvy @pfn-ci-bot @chainer-ci @asi1024