Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify F.separate test #7013

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Simplify F.separate test #7013

merged 1 commit into from
Apr 22, 2019

Conversation

hikjik
Copy link

@hikjik hikjik commented Apr 21, 2019

Simplifies test_separate using testing.FunctionTestCase
Refer to #6071

@Crissman Crissman self-assigned this Apr 22, 2019
@Crissman
Copy link
Member

LGTM. Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit e6857ae (e4fa098):

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e6857ae, target branch master) succeeded!

@Crissman
Copy link
Member

Merging.

@Crissman Crissman merged commit 471c140 into chainer:master Apr 22, 2019
@hikjik hikjik deleted the simplify-separate-test branch April 23, 2019 11:40
@niboshi niboshi mentioned this pull request May 14, 2019
Closed
@Crissman Crissman modified the milestones: v6.0.0, v7.0.0a1 May 14, 2019
@Crissman Crissman added the cat:test Test or CI related. label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Crissman Crissman

Labels
cat:test Test or CI related.
Projects
None yet
Milestone
v7.0.0a1
Development

Successfully merging this pull request may close these issues.
4 participants
@hikjik @Crissman @pfn-ci-bot @chainer-ci