Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky chainerx.abs test #7024

Merged
merged 1 commit into from May 8, 2019
Merged

Fix flaky chainerx.abs test #7024

merged 1 commit into from May 8, 2019

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Apr 22, 2019

Fix #6912.
Fixed to avoid non-differentiable inputs.

@asi1024 asi1024 added the cat:test Test or CI related. label Apr 22, 2019
@asi1024 asi1024 changed the title Fix flaky chainerx.abs Fix flaky chainerx.abs test Apr 22, 2019
@hvy
Copy link
Member

hvy commented Apr 23, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 4dab280 (d8045ce):

@hvy hvy added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Apr 23, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4dab280, target branch master) failed with status FAILURE.

@hvy
Copy link
Member

hvy commented May 7, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 4dab280:

1 similar comment
@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 4dab280:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4dab280, target branch master) failed with status FAILURE.

@hvy
Copy link
Member

hvy commented May 8, 2019

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 4dab280:

1 similar comment
@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 4dab280:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4dab280, target branch master) succeeded!

@hvy
Copy link
Member

hvy commented May 8, 2019

LGTM!

@hvy hvy merged commit e392131 into chainer:master May 8, 2019
@hvy hvy added ChainerX Related to ChainerX. and removed st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels May 8, 2019
@hvy hvy added this to the v7.0.0a1 milestone May 8, 2019
@asi1024 asi1024 deleted the flaky-absolute branch May 8, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hvy hvy

Labels
cat:test Test or CI related. ChainerX Related to ChainerX.
Projects
None yet
Milestone
v7.0.0a1
Development

Successfully merging this pull request may close these issues.

test_math is flaky
4 participants
@asi1024 @hvy @pfn-ci-bot @chainer-ci