Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Avoid importing object #7121

Merged
merged 1 commit into from
May 14, 2019
Merged

[backport] Avoid importing object #7121

merged 1 commit into from
May 14, 2019

Conversation

kmaehashi
Copy link
Member

Backport of #7110

@kmaehashi kmaehashi added backport Pull request that is backported from a more recent version. cat:code-fix Code refactoring that does not change the behavior. labels May 13, 2019
@kmaehashi
Copy link
Member Author

[automatic post] Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e677043, target branch v6) succeeded!

@niboshi niboshi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label May 13, 2019
@niboshi niboshi self-assigned this May 13, 2019
@niboshi
Copy link
Member

niboshi commented May 14, 2019

LGTM

@niboshi niboshi merged commit 0fe2584 into chainer:v6 May 14, 2019
@niboshi niboshi added this to the v6 milestone May 14, 2019
@niboshi
Copy link
Member

niboshi commented May 14, 2019

Travis indicator is still yellow but it seems it passed actually.

@kmaehashi kmaehashi modified the milestones: v6, v6.0.0 May 16, 2019
@kmaehashi kmaehashi deleted the bp-7110-avoid-import-object branch May 16, 2019 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
backport Pull request that is backported from a more recent version. cat:code-fix Code refactoring that does not change the behavior. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kmaehashi @chainer-ci @niboshi