Remove duplicated code in logic.cc #7176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asi1024
added
ChainerX
hvy
requested changes
May 20, 2019
|
Wrote some comments, could you take a look? |
|
Jenkins, test this please. |
hvy
added
the
st:test-and-merge
hvy
reviewed
May 20, 2019
hvy
removed
the
st:test-and-merge
|
Jenkins, test this please. |
hvy
added
the
st:test-and-merge
|
Jenkins CI test (for commit 734a413, target branch master) failed with status FAILURE. |
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 734a413, target branch master) failed with status FAILURE. |
hvy
approved these changes
May 21, 2019
|
Jenkins, test this please. |
|
Jenkins CI test (for commit 05deb2d, target branch master) failed with status FAILURE. |
|
Failure seems unrelated, LGTM! |
hvy
removed
the
st:test-and-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for #7143.