Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fallback for ChainerX in F.accuracy #7396

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Jun 4, 2019

Split from #7393

Implements chainerx_forward in F.accuracy.
The base class is now FunctionNode instead of Function in order to support chainerx_forward.

@hvy hvy added the ChainerX Related to ChainerX. label Jun 5, 2019
@niboshi
Copy link
Member Author

niboshi commented Aug 14, 2019

ping

@kmaehashi
Copy link
Member

pfnCI, test this please.

@kmaehashi kmaehashi added the cat:enhancement Implementation that does not break interfaces. label Nov 1, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit f6c5b70, target branch master) succeeded!

@niboshi
Copy link
Member Author

niboshi commented Nov 1, 2019

Resolved conflict.
PTAL

@kmaehashi
Copy link
Member

pfnCI, test this please.

@kmaehashi kmaehashi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 7, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 32feb13, target branch master) succeeded!

@mergify mergify bot merged commit 0deca4b into chainer:master Nov 7, 2019
@niboshi niboshi deleted the chainerx-accuracy branch November 7, 2019 06:01
@kmaehashi kmaehashi added this to the v7.0.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces. ChainerX Related to ChainerX. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants