Fix multi-device loss scaling #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
force-pushed
the
optimizer-multidevice-loss-scale
branch
from
1610d58
to
5a26c2b
Compare
hvy
reviewed
Jun 25, 2019
|
Could you rebase now that #7590 is merged? |
hvy
added
the
st:awaiting-author
|
Conflict resolved. |
|
Sorry could you resolve the conflicts again? |
|
Resolved. |
hvy
removed
the
st:awaiting-author
|
Jenkins, test this please. |
|
Jenkins CI test (for commit d2e2911, target branch master) succeeded! |
|
LGTM! |
|
To be backported? |
hvy
added a commit
to hvy/chainer
that referenced
this pull request
Aug 19, 2019
…ss-scale Fix multi-device loss scaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateRule.updatedoes not handle multiple devices with loss scaling.Merge after #7590