Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Fix in-place update of arrays in Link.serialize and optimizers.Adam #7941

Merged
merged 2 commits into from Aug 15, 2019
Merged

[backport] Fix in-place update of arrays in Link.serialize and optimizers.Adam #7941

merged 2 commits into from Aug 15, 2019

Conversation

emcastillo
Copy link
Member

Backport of #7918

@mergify
Merge pull request chainer#7918 from niboshi/fix-colon-index
e8670c8 
Fix in-place update of arrays in `Link.serialize` and `optimizers.Adam`
@emcastillo
Copy link
Member Author

[automatic post] Jenkins, test this please.

@emcastillo emcastillo added backport Pull request that is backported from a more recent version. cat:bug Bug report or fix. prio:high High priority. Urgent and needs to be worked on as soon as possible. labels Aug 15, 2019
niboshi
niboshi requested changes Aug 15, 2019
View reviewed changes
tests/chainer_tests/test_link.py Outdated Show resolved Hide resolved
@niboshi niboshi added the st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. label Aug 15, 2019
@emcastillo
Copy link
Member Author

PTAL.
Some of the optimizers were not explicitly implemented in the stable version so they had to be skipped too

@niboshi
Copy link
Member

niboshi commented Aug 15, 2019

Jenkins, test this please

@niboshi niboshi added st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. and removed st:awaiting-author State indicating that response is needed from contributors, often authors of pull request. labels Aug 15, 2019
@niboshi niboshi added this to the v6.3.0 milestone Aug 15, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 4fd6fd2, target branch v6) succeeded!

@mergify mergify bot merged commit 0bf4382 into chainer:v6 Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niboshi niboshi niboshi approved these changes

Assignees

@niboshi niboshi

Labels
backport Pull request that is backported from a more recent version. cat:bug Bug report or fix. prio:high High priority. Urgent and needs to be worked on as soon as possible. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emcastillo @niboshi @chainer-ci