Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stable version section from README #7956

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Remove stable version section from README #7956

merged 1 commit into from
Feb 5, 2020

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Aug 15, 2019

Related: #7948

I don't know how this section would be useful.

@asi1024 asi1024 added the st:needs-discussion State indicating that discussions are needed before proceeding. label Aug 16, 2019
@kmaehashi
Copy link
Member

I think we need to leave it as is for users. Without it, there's no explicit link for v6 branch; v6 users cannot find the codebase and examples.

@Hakuyume
Copy link
Member

In the README, Examples is linked to master branch, where Docs, Install Guide, and Concepts are linked to stable. How about changing Examples to refer stable examples? With this modification, we can remove stable version section, I think.

@kmaehashi kmaehashi mentioned this pull request Nov 11, 2019
Merged
@kmaehashi
Copy link
Member

In the README, Examples is linked to master branch, where Docs, Install Guide, and Concepts are linked to stable. How about changing Examples to refer stable examples? With this modification, we can remove stable version section, I think.

Thanks for pointing that issue out. However I still think it's unreasonable to reduce information only to cut our cost to bump the version after major release.

@kmaehashi kmaehashi added this to the v7.2.0 milestone Jan 28, 2020
@niboshi niboshi closed this Feb 4, 2020
@niboshi niboshi deleted the readme-remove-stable branch February 4, 2020 07:47
@kmaehashi kmaehashi added cat:document Documentation such as function documentations, comments and tutorials. and removed st:needs-discussion State indicating that discussions are needed before proceeding. labels Feb 4, 2020
@niboshi niboshi restored the readme-remove-stable branch February 4, 2020 07:52
@niboshi niboshi reopened this Feb 5, 2020
@kmaehashi
Copy link
Member

pfnCI, test this please.

As v7 is now the only stable version, I agree with removing this.

@kmaehashi kmaehashi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Feb 5, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 75f2596, target branch master) succeeded!

@mergify mergify bot merged commit 24771e2 into chainer:master Feb 5, 2020
@niboshi niboshi deleted the readme-remove-stable branch February 5, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kmaehashi kmaehashi

Labels
cat:document Documentation such as function documentations, comments and tutorials. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@niboshi @kmaehashi @Hakuyume @chainer-ci @asi1024