Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to examples directory for the current branch #8403

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

kmaehashi
Copy link
Member

As pointed out in #7956 (comment), Examples links to master branch even when a user is browsing other branch.

@kmaehashi kmaehashi added cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported. labels Nov 11, 2019
@takagi takagi self-assigned this Nov 11, 2019
@takagi takagi added this to the v7.0.0 milestone Nov 11, 2019
@takagi
Copy link
Member

takagi commented Nov 11, 2019

pfnCI, test this please.

@takagi
Copy link
Member

takagi commented Nov 11, 2019

LGTM! Waiting for CI finish.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 57d1dbd, target branch master) failed with status FAILURE.

@takagi
Copy link
Member

takagi commented Nov 12, 2019

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 57d1dbd, target branch master) succeeded!

@takagi
Copy link
Member

takagi commented Nov 13, 2019

LGTM!

@takagi takagi merged commit 52dadb2 into chainer:master Nov 13, 2019
takagi added a commit to takagi/chainer that referenced this pull request Nov 13, 2019
Link to examples directory for the current branch
@kmaehashi kmaehashi deleted the fix-readme-example-link branch November 13, 2019 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants