Correctly cast fill_value in constant initializer
#8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
requested changes
Sep 9, 2019
hvy
force-pushed
the
fix-constant-init
branch
from
ac46d82
to
1b9801c
Compare
hvy
force-pushed
the
fix-constant-init
branch
from
1b9801c
to
49831d2
Compare
niboshi
added
cat:bug
|
LGTM |
niboshi
approved these changes
Sep 9, 2019
niboshi
added
the
st:awaiting-member
|
Jenkins, test this please |
niboshi
added
st:test-and-merge
|
Jenkins CI test (for commit 49831d2, target branch master) succeeded! |
|
This bug was introduced in #8022: no need to backport. |
This was referenced Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #8043 on request per @toslunar.