Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate multinode checkpointer #8207

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Deprecate multinode checkpointer #8207

merged 4 commits into from
Oct 8, 2019

Conversation

kuenishi
Copy link
Member

@kuenishi kuenishi commented Oct 1, 2019

Indirectly addresses #6232 by deprecating it (it was experimental feature, though).

@kuenishi kuenishi added cat:other Ticket that do not fall into any other cat-label. ChainerMN Related to ChainerMN. labels Oct 1, 2019
@kuenishi kuenishi mentioned this pull request Oct 3, 2019
Closed
@kuenishi kuenishi requested a review from shmurai October 3, 2019 05:46
@shmurai
Copy link
Contributor

shmurai commented Oct 4, 2019

tests/chainermn_tests/datasets_tests/test_mnist.py fails because it internally uses create_multi_node_checkpointer.
https://github.com/kuenishi/chainer/blob/34b0c229bc41769daa3bffa3c1356508b6535b7a/tests/chainermn_tests/datasets_tests/test_mnist.py#L76
Could you fix this?

@kuenishi kuenishi self-assigned this Oct 7, 2019
@kuenishi
Copy link
Member Author

kuenishi commented Oct 7, 2019

Added DeprecationWarning filter and removed related examples.

@shmurai
Copy link
Contributor

shmurai commented Oct 8, 2019

LGTM.
Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 7d3ebd0, target branch master) failed with status FAILURE.

@shmurai
Copy link
Contributor

shmurai commented Oct 8, 2019

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 7d3ebd0, target branch master) failed with status FAILURE.

@kuenishi
Copy link
Member Author

kuenishi commented Oct 8, 2019

Jenkins, test this please.
/test

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 7d3ebd0, target branch master) succeeded!

@kuenishi kuenishi merged commit 4994f3d into chainer:master Oct 8, 2019
@kuenishi kuenishi deleted the deprecate-checkpointer branch October 8, 2019 08:51
@kmaehashi kmaehashi added this to the v7.0.0rc1 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmurai shmurai shmurai left review comments

Assignees

@kuenishi kuenishi

Labels
cat:other Ticket that do not fall into any other cat-label. ChainerMN Related to ChainerMN.
Projects
None yet
Milestone
v7.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuenishi @shmurai @chainer-ci @kmaehashi