New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CHAINER_TEST_PAIRWISE_PARAMETERIZATION
and enable it only in Travis CI
#8211
Conversation
0519675
to
95df9fa
Compare
CHAINER_TEST_PAIRWISE_PARAMETERIZE
and enable it only in Travis CICHAINER_TEST_PAIRWISE_PARAMETERIZATION
and enable it only in Travis CI
95df9fa
to
9166dbb
Compare
9166dbb
to
23d944f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for introducing the env variable.
On moving the code to tests/conftest.py
,
- I confirmed that PyTest (4.1.1) reads multiple
conftest.py
files. - Could you fix the TODO comment on
_product_dict_orig
inchainer/testing/parameterized.py
? ("is patched by tests/conftest.py") - I'd like to hear ChainerMN team's comment on the pairwise testing.
Fixed in ef3c7e2.
I don't think we should enable pairwise testing in |
CHAINER_TEST_PAIRWISE_PARAMETERIZATION
and enable it only in Travis CICHAINER_TEST_PAIRWISE_PARAMETERIZATION
and enable it only in Travis CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins, test this please |
Jenkins CI test (for commit ef3c7e2, target branch master) failed with status FAILURE. |
Jenkins error might be related |
I don't think it's needed. I meant that chainer/tests/chainermn_tests/functions_tests/test_pseudo_connect.py Lines 13 to 17 in 3a184c8
|
@toslunar |
@emcastillo |
I see. Could you fix |
48 min 41 sec with macOS https://travis-ci.org/chainer/chainer/builds/592878722 where pairwise testing is applied to |
@toslunar I see. That sounds good. |
@emcastillo This pull-request is marked as |
2 similar comments
@emcastillo This pull-request is marked as |
@emcastillo This pull-request is marked as |
Jenkins, test this please |
Jenkins CI test (for commit f5db68b, target branch master) succeeded! |
See #8210
Adding
CHAINER_TEST_PAIRWISE_PARAMETERIZATION
environment variable and only set it toalways
in Travis CI.