Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resize_images documentation to reflect recent code changes #8221

Merged
merged 1 commit into from Oct 3, 2019

Conversation

zu3st
Copy link
Contributor

@zu3st zu3st commented Oct 2, 2019

Recently, a nearest mode was added to resize_images: f8b3524
The function documentation should reflect this.

@hvy
Copy link
Member

hvy commented Oct 3, 2019

Good catch and thanks for the PR. Let me just check the CI because it LGTM. We could by the way add a more detailed description in the docs about the different modes but it can be addressed in a separate issue.

@hvy
Copy link
Member

hvy commented Oct 3, 2019

Jenkins, test this please.

@hvy hvy added cat:document Documentation such as function documentations, comments and tutorials. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Oct 3, 2019
@hvy hvy added this to the v7.0.0rc1 milestone Oct 3, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 77b0abe, target branch master) succeeded!

@hvy
Copy link
Member

hvy commented Oct 3, 2019

CI failures are unrelated, let me merge this PR.

@hvy hvy merged commit 6e89871 into chainer:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants