Simplify direction vector sampling in gradient_check
#8238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
added
the
cat:code-fix
niboshi
force-pushed
the
simplify-direction-vector
branch
from
4bebcca
to
b676495
Compare
toslunar
approved these changes
Oct 10, 2019
|
Jenkins & flexCI, test this please. |
toslunar
added
the
st:test-and-merge
toslunar
reviewed
Oct 10, 2019
| sizes = [int(numpy.prod(shape)) for shape in shapes] | ||
| cumsizes = numpy.cumsum(sizes) | ||
| unpacked_arrays = [ | ||
| packed_array[cumsize - size:cumsize].reshape(shape) |
There was a problem hiding this comment.
OK to return views because they are only used in perturb.
|
Jenkins CI test (for commit b676495, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8236
Simplifies the implementation of direction vector sampling in
gradient_check, by avoiding repeated loops.