-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_Meshgrid #8285
Fix test_Meshgrid #8285
Conversation
Thanks. Were you able to replicate the original errors, and how many times did you run this to confirm ok? |
I've not tried it. IMO, the PR removes some bad tests, while weakening tolerance of a test is often a trade-off action where the frequency of failures may be measured first. The cause seems independent of backend because I found test failures with devices |
Repeated this change with |
To test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins, test this please |
Thanks @hvy for measuring the failure rate. I updated the PR comment to keep the issue open. |
Jenkins CI test (for commit 1d11f53, target branch master) succeeded! |
Probably this fixes #8268. (Reopen the issue later if it does not.)This PR reduces the failure rate of
test_Meshgrid
.The outputs are six arrays of the shape
(6, 5, 3, 3, 6, 3)
, which seems too big to test backward withfloat16
, in the failed example.