Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_Meshgrid #8285

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Fix test_Meshgrid #8285

merged 1 commit into from
Oct 31, 2019

Conversation

toslunar
Copy link
Member

@toslunar toslunar commented Oct 10, 2019

Probably this fixes #8268. (Reopen the issue later if it does not.)
This PR reduces the failure rate of test_Meshgrid.

The outputs are six arrays of the shape (6, 5, 3, 3, 6, 3), which seems too big to test backward with float16, in the failed example.

@toslunar toslunar added the cat:test Test or CI related. label Oct 10, 2019
@Crissman Crissman self-assigned this Oct 11, 2019
@Crissman
Copy link
Member

Crissman commented Oct 11, 2019

Thanks. Were you able to replicate the original errors, and how many times did you run this to confirm ok?

@toslunar
Copy link
Member Author

Were you able to replicate the original errors, and how many times did you run this to confirm ok?

I've not tried it. IMO, the PR removes some bad tests, while weakening tolerance of a test is often a trade-off action where the frequency of failures may be measured first.

The cause seems independent of backend because I found test failures with devices native:0 and cuda:0.

@hvy
Copy link
Member

hvy commented Oct 23, 2019

Repeated this change with --count 1000 and it failed once with input_arrs=4, indexing='ij', float16, cudaon the backward test. Maybe 4 is still too high?

@toslunar
Copy link
Member Author

To test indexing, I was not so brave to drop input_arrs=4.

  • indexing='xy' (default): 1, 0, 2, ..., N-1
  • indexing='ij': 0, ..., N-1

@emcastillo emcastillo self-assigned this Oct 29, 2019
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Oct 31, 2019
@emcastillo emcastillo added this to the v7.0.0 milestone Oct 31, 2019
@toslunar
Copy link
Member Author

Thanks @hvy for measuring the failure rate. I updated the PR comment to keep the issue open.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1d11f53, target branch master) succeeded!

@mergify mergify bot merged commit 91918b5 into chainer:master Oct 31, 2019
@toslunar toslunar deleted the fix-test-meshgrid branch October 31, 2019 07:23
@toslunar toslunar mentioned this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants