Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean up for routines/indexing.h #8288

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Code clean up for routines/indexing.h #8288

merged 1 commit into from
Oct 31, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Oct 11, 2019

Including #8281 (comment)

@emcastillo emcastillo self-assigned this Oct 11, 2019
emcastillo
emcastillo approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 7c2072d, target branch master) succeeded!

@emcastillo emcastillo mentioned this pull request Oct 28, 2019
Merged
@emcastillo
Copy link
Member

I think we can close this one.
Thanks!

@emcastillo emcastillo closed this Oct 30, 2019
@niboshi
Copy link
Member Author

niboshi commented Oct 30, 2019

Some subtle fixes are still applicable.
I'll update the PR.

@niboshi niboshi reopened this Oct 30, 2019
@niboshi
Copy link
Member Author

niboshi commented Oct 30, 2019

PTAL

emcastillo
emcastillo approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added cat:code-fix Code refactoring that does not change the behavior. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Oct 30, 2019
@emcastillo emcastillo added this to the v7.0.0 milestone Oct 30, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit fefcb27, target branch master) succeeded!

@mergify mergify bot merged commit 9a38c40 into chainer:master Oct 31, 2019
@niboshi niboshi deleted the chx-indexing-header branch October 31, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emcastillo emcastillo emcastillo approved these changes

Assignees

@emcastillo emcastillo

Labels
cat:code-fix Code refactoring that does not change the behavior. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niboshi @emcastillo @chainer-ci