-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default index mode for chainerx Take
#8281
Conversation
PTAL |
chainerx_cc/chainerx/array_index.h
Outdated
@@ -16,6 +16,14 @@ enum class ArrayIndexTag { | |||
kEllipsis, | |||
}; | |||
|
|||
enum class IndexBoundsMode { | |||
// Index out-of-bounds handling modes for take |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remove this comment or update it with all the routines that support it
choose
also allows index mode kwarg
This basically LGTM, @niboshi may I proceed with merging it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some additional comments. Please check.
Comments addressed! thanks a lot :)! |
Thanks |
Jenkins CI test (for commit 6a41596, target branch master) succeeded! |
Allows the examples to be built
Closes #8276